fix(remote-chat): key a remote chat by its room, so one published room is one row (#2797) - #2801

Verdict: PASS at 1b2b39c
Written-by: Reviewer
Attestation: 1b2b39c role=Reviewer

Ran at this tip:

$ TZ=UTC node --import ./test/harness-resolve.mjs --test --test-timeout=120000 test/remote-chat.test.js test/remote-room.test.js test/friend-chat-awaiting.test.js test/new-chat.test.js test/mention-style.test.js
# tests 163  # pass 163  # fail 0
$ TZ=UTC node --import ./test/harness-resolve.mjs --test --test-concurrency=4 --test-timeout=120000 "test/*.test.js"
# tests 2624  # pass 2525  # fail 97
$ same full run on a clean extract of base 5b8d980fd15771c20e8464cc0711b2c543be8694
# tests 2620  # pass 2521  # fail 97  (the two failure lists are identical, 97 of 97, no tip-only name)
$ cp the base blob a9dd1d853f1ab10dbde955a3ce3c2316fc9b264d over core/src/host/remote-chat.js in the tip tree, then TZ=UTC node --import ./test/harness-resolve.mjs --test --test-timeout=120000 test/remote-chat.test.js
# tests 25  # pass 22  # fail 3
$ node scripts/ds-bot-patches.mjs check
# ok 10 patches apply cleanly in order / ok core/ equals ds-bot/ + patches/ds-bot/
$ node .github/scripts/changelog.mjs check
# changelog: 22 fragment(s) in changelog.d/ are well formed
$ git hash-object core/src/host/remote-chat.js core/test/remote-chat.test.js
# fdc30cbac16e514aa3166fda64c77e47da49f22a / 1f789bbf3b404ed8c40bc028862c0a0412c46ccf  (the blobs the PR diff names)

Not run: npm --prefix plugins/* test and the .github/scripts/policy suites here (CI ran them at this tip and they are green — plugins (social|tree|timeline|workflow), policy-sign, judge, tests-ok all success); node .github/scripts/enqueue-rules.mjs (the guard check on this tip already reports one reason only); dev/bench.sh smoke (needs a harness checkout and git).

Where the duplicate was — list layer, not publication. Before this change core/src/host/remote-chat.js keyed a remote chat by the handle it arrived on: chatOfHandle compares normRemoteHandle(bot.remote.handle) against normRemoteHandle(handle) (open(), line 232 at base) and sync() decided gone from the same handle set. The publisher names one room once per member — same name (the room title) at the same home, a different member handle each — so one room opened one chat per member, which is the owner's 8+ identical rows; and when the handle carrying the room changed, sync() marked the old chat gone and opened a new one, so the count only grew. The change adds roomKeyOf (published name at that home, name cut at 40 the way a chat's stored name is cut) and: open() falls back to chatOfRoom({ home, name, plugin }) when no chat holds the handle (core/src/host/remote-chat.js:254), sync() opens each room once (:290-294) and keeps it live while any of its members is still published (:301). The stored remote.handle is left alone on purpose — the model route flybot-remote/<handle> names it.

Not a UI fold. No client or list-rendering file is in the diff (compare 5b8d980…1b2b39c4 is 1 commit, 6 files); list() keeps returning every chat record unchanged, and nothing is hidden or merged at render time. Two names at one home, and one name at two homes, stay two rows — the PR's own control case proves the rule never folds a list, and it passes on base as well as at the tip.

Red first, on base. Putting the base blob of core/src/host/remote-chat.js back under this tip's test file turns exactly the three #2797 cases red — one room 4 !== 1, a changed member handle 2 !== 1 with the old copy gone, and deliver landing on 'b2' !== 'b1' — while the control case stays green. The three assertions fail before the fix and pass after it, so the tests bite.

User-visible change has its fragment. changelog.d/2797-remote-room-one-row.fixed.md is in the diff, one line, names #2797, and changelog.mjs check accepts it.

Scope and shape. The six changed files are exactly the fix, its tests, its docs line, the changelog fragment, and the patches/ds-bot/files/ mirrors — and the mirror blobs equal the core/ blobs (fdc30cba, 1f789bbf), which ds-bot-patches check confirms both ways. Nothing under policy/, .github/scripts/, .github/workflows/, no hold, no other PR.

CI at this tip. 22 check runs; every one success or skipped (live · real model, window check are skipped by design), except enqueue-guard — which is red for exactly one reason, no Verifier report names the tip 1b2b39c446ab, i.e. this verdict was missing. That is its only objection.

The full-suite 97 failures are this box, not the diff: with no esbuild / jsdom devDeps installed and no git binary, the base tree fails the same 97 tests (identical names, set difference empty both ways).

Body metadata is in order: Owner: Chief, Reviewer: Reviewer (not the same name), label agent-pr, and the ## Checkpoint block is 1158 characters with a 548-character summary naming this tip.